Trial Spawner and Vaults 1.21 additions #2790
Conversation
| // | ||
| // @Location true | ||
| // | ||
| // @Triggers when a vault block state changes |
There was a problem hiding this comment.
Needs to be block's or block changes state.
Also . at the end.
| // <context.old_state> returns the vault state before the change. | ||
| // <context.new_state> returns the vault state after the change. |
There was a problem hiding this comment.
Needs some reference/link as to what the states are, maybe just one link in Triggers (but can also be here if you prefer)
| public BlockDispenseLootScriptEvent() { | ||
| registerCouldMatcher("loot dispenses from <block>"); | ||
| this.<BlockDispenseLootScriptEvent, ListTag>registerDetermination(null, ListTag.class, (evt, context, input) -> { | ||
| List<ItemStack> items = new ArrayList<>(); |
There was a problem hiding this comment.
Nitpick, but can initialize to input.size().
| @Override | ||
| public ObjectTag getContext(String name) { | ||
| return switch (name) { | ||
| case "item" -> item; |
There was a problem hiding this comment.
This has the same issue with the context potentially becoming outdated due to another plugin accessing it (e.g. if you - wait a bit in a script and then read it) - need to dynamically get the item here, but can keep the field for matches optimization.
|
|
||
| public BlockDispenseLootScriptEvent() { | ||
| registerCouldMatcher("loot dispenses from <block>"); | ||
| this.<BlockDispenseLootScriptEvent, ListTag>registerDetermination(null, ListTag.class, (evt, context, input) -> { |
There was a problem hiding this comment.
Just in general, prefixed determinations (to match their context counterparts) are usually preferred as they're easier to understand in scripts & look cleaner if the event ever gets more than one determination.
| || data instanceof Tripwire | ||
| || (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19) && (data instanceof SculkCatalyst | ||
| || data instanceof SculkShrieker)); | ||
| || data instanceof SculkShrieker)) |
| else if (isSculkCatalyst()) { | ||
| return ((SculkCatalyst) material.getModernData()).isBloom() ? "BLOOM" : "NORMAL"; // TODO: 1.19 | ||
| else if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21) && getBlockData() instanceof TrialSpawner trialSpawner) { | ||
| return new ElementTag(trialSpawner.getTrialSpawnerState().name(), true); |
There was a problem hiding this comment.
Can use the enum constructor for these
2 participants
Replaces #2771
Additions:
Updates:
Some of this was copied from @MrMaleficus's earlier PR, so credit to them for the events.